[all-commits] [llvm/llvm-project] f2c8f6: [clangd] Log rather than assert on bad UTF-8.

Sam McCall via All-commits all-commits at lists.llvm.org
Wed Jun 10 02:40:44 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f2c8f6e16d25ca356f58995109292735b222b1b7
      https://github.com/llvm/llvm-project/commit/f2c8f6e16d25ca356f58995109292735b222b1b7
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-06-10 (Wed, 10 Jun 2020)

  Changed paths:
    M clang-tools-extra/clangd/SourceCode.cpp
    M clang-tools-extra/clangd/unittests/SourceCodeTests.cpp
    M clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp

  Log Message:
  -----------
  [clangd] Log rather than assert on bad UTF-8.

Summary:
I don't love this behavior, but it prevents crashing when indexing boost
headers, and I can't think of a better practical alternative.

Fixes https://reviews.llvm.org/D81530

Based on a patch by AnakinZheng!

Reviewers: kadircet

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits, AnakinZheng

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81530




More information about the All-commits mailing list