[all-commits] [llvm/llvm-project] d9bc8b: [RISCV] Make visibility of overridden methods in R...

Alex Bradbury via All-commits all-commits at lists.llvm.org
Wed Jun 10 01:27:04 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d9bc8bd54a703c2f79c429c2bbca89db4ae4f073
      https://github.com/llvm/llvm-project/commit/d9bc8bd54a703c2f79c429c2bbca89db4ae4f073
  Author: Alex Bradbury <asb at lowrisc.org>
  Date:   2020-06-10 (Wed, 10 Jun 2020)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVISelLowering.h

  Log Message:
  -----------
  [RISCV] Make visibility of overridden methods in RISCVISelLowering match the parent

Currently, some fairly arbitrary subset of overriden methods in
RISCVISelLowering are private rather than public (which is the
visibility they have in TargetLowering). I suspect this is a holdover
from too closely copying another backend.

D78545 pointed out this can be difficult for some downstream patches,
and nobody has come forward to suggest a reason for keeping the
visibility as-is.

This commit simply makes all overridden methods match the public
visiblity of the parent.

Differential Revision: https://reviews.llvm.org/D79928




More information about the All-commits mailing list