[all-commits] [llvm/llvm-project] 9e9142: Patch up issues with GN builds (pthread / libz)

[Mitch Phillips via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9e9142cbb90901cd0e96a73d14382721250a4069
      https://github.com/llvm/llvm-project/commit/9e9142cbb90901cd0e96a73d14382721250a4069
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/utils/gn/build/libs/pthread/BUILD.gn

  Log Message:
  -----------
  Patch up issues with GN builds (pthread / libz)

Summary:
Fixes up two small issues with the gn build.

 1 - Ensures that the correct ldflag `-pthread` is provided, not just linking the library.
 2 - Ensures that libraries are linked in the same group as the dependencies. This fixes a problem where system libraries (libc) are involved in a link-order dependency that's not being fulfilled.

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80591


  Commit: 184b437699d31e189091facbfdd3b2acb7016142
      https://github.com/llvm/llvm-project/commit/184b437699d31e189091facbfdd3b2acb7016142
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/utils/gn/build/toolchain/BUILD.gn

  Log Message:
  -----------
  Move DSO dependencies inside the group.


  Commit: 1bfb5b8e362f0c586a50c8f80ebf07bcb37f856d
      https://github.com/llvm/llvm-project/commit/1bfb5b8e362f0c586a50c8f80ebf07bcb37f856d
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/utils/gn/build/libs/pthread/BUILD.gn
    M llvm/utils/gn/build/toolchain/BUILD.gn

  Log Message:
  -----------
  Address Peter's comments.


  Commit: 2ecf32fb35255693448f14270c30878853e77b5f
      https://github.com/llvm/llvm-project/commit/2ecf32fb35255693448f14270c30878853e77b5f
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/utils/gn/build/libs/pthread/BUILD.gn

  Log Message:
  -----------
  remove redundant comment about Android.


  Commit: 9bca45bd45ebb0abb676bcdce2a8436396203460
      https://github.com/llvm/llvm-project/commit/9bca45bd45ebb0abb676bcdce2a8436396203460
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/utils/gn/build/toolchain/BUILD.gn

  Log Message:
  -----------
  Rebase.


  Commit: e26b25f8b1fdbc088abdfab933d909960989c64b
      https://github.com/llvm/llvm-project/commit/e26b25f8b1fdbc088abdfab933d909960989c64b
  Author: Mitch Phillips <31459023+hctim at users.noreply.github.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M compiler-rt/lib/hwasan/CMakeLists.txt
    M compiler-rt/lib/hwasan/hwasan.cpp
    A compiler-rt/lib/hwasan/hwasan_globals.cpp
    A compiler-rt/lib/hwasan/hwasan_globals.h
    M compiler-rt/lib/hwasan/hwasan_report.cpp
    M compiler-rt/lib/sanitizer_common/sanitizer_common.h
    M compiler-rt/test/hwasan/TestCases/global.c
    M llvm/utils/gn/build/libs/pthread/BUILD.gn
    M llvm/utils/gn/secondary/compiler-rt/lib/hwasan/BUILD.gn

  Log Message:
  -----------
  [HWASan] Add sizeof(global) in report even if symbols missing.

Summary: Refactor the current global header iteration to be callback-based, and add a feature that reports the size of the global variable during reporting. This allows binaries without symbols to still report the size of the global variable, which is always available in the HWASan globals PT_NOTE metadata.

Reviewers: eugenis, pcc

Reviewed By: pcc

Subscribers: mgorny, llvm-commits, #sanitizers

Tags: #sanitizers, #llvm

Differential Revision: https://reviews.llvm.org/D80599


Compare: https://github.com/llvm/llvm-project/compare/a7e0d55de09e...e26b25f8b1fd