[all-commits] [llvm/llvm-project] bb6cb6: GlobalISel: Remove redundant check in verifier

[Matt Arsenault via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bb6cb6bfe413e1f3e368f1bf0550a7517d7c8d66
      https://github.com/llvm/llvm-project/commit/bb6cb6bfe413e1f3e368f1bf0550a7517d7c8d66
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/lib/CodeGen/MachineVerifier.cpp

  Log Message:
  -----------
  GlobalISel: Remove redundant check in verifier

This was already checked earlier for all instructions.


  Commit: babbf4441b6022a2d76f831316b7c3588ade9e15
      https://github.com/llvm/llvm-project/commit/babbf4441b6022a2d76f831316b7c3588ade9e15
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
    M llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp

  Log Message:
  -----------
  GlobalISel: Move some trivial MIRBuilder methods into the header

The construction APIs for MachineIRBuilder don't make much sense, and
it's been annoying to sort through it with these trivial functions
separate from the declaration.


  Commit: b94c9e3b55ab97f6646018dec2c1d3647c04cda3
      https://github.com/llvm/llvm-project/commit/b94c9e3b55ab97f6646018dec2c1d3647c04cda3
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-09 (Tue, 09 Jun 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
    M llvm/lib/CodeGen/GlobalISel/Legalizer.cpp
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

  Log Message:
  -----------
  GlobalISel: Improve MachineIRBuilder construction

The current relationship between LegalizerHelper and MachineIRBuilder
confuses me, because the LegalizerHelper modifies the MachineIRBuilder
which it does not own. Constructing a LegalizerHelper destroys the
insert point, since the constructor calls setMF, which clears all the
fields. Try to separate these functions, so it's possible to construct
a LegalizerHelper from an existing MachineIRBuilder without losing the
insert point/debug loc.


Compare: https://github.com/llvm/llvm-project/compare/6eeac6ae3304...b94c9e3b55ab