[all-commits] [llvm/llvm-project] 2ef65a: [Sema][CodeComplete][ObjC] Don't include arrow/dot...

[David Goldman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ef65adb6f9dbebdd250dc6210e813711fb478d9
      https://github.com/llvm/llvm-project/commit/2ef65adb6f9dbebdd250dc6210e813711fb478d9
  Author: David Goldman <davg at google.com>
  Date:   2020-06-08 (Mon, 08 Jun 2020)

  Changed paths:
    M clang/lib/Sema/SemaCodeComplete.cpp
    A clang/test/CodeCompletion/objc-member-access.m

  Log Message:
  -----------
  [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

Summary:
Exempt ObjC from arrow/dot fixits since this has limited value for
Objective-C, where properties (referenced by dot syntax) are normally
backed by ivars (referenced by arrow syntax).

In addition, the current implementation doesn't properly mark
the fix it condition for Objective-C.

This was initially added in https://reviews.llvm.org/D41537
for C++ and then later C, don't believe the Objective-C changes
were intentional.

Reviewers: sammccall, yvvan

Subscribers: jfb, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D81263