[all-commits] [llvm/llvm-project] 38fb44: AMDGPU/GlobalISel: Fix test failure in release build

Matt Arsenault via All-commits all-commits at lists.llvm.org
Sat Jun 6 08:01:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 38fb446fc7fc7683d230f93ade61d5d41c3587bd
      https://github.com/llvm/llvm-project/commit/38fb446fc7fc7683d230f93ade61d5d41c3587bd
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-06 (Sat, 06 Jun 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPU.td
    M llvm/lib/Target/AMDGPU/DSInstructions.td
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-atomicrmw-fadd-local.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Fix test failure in release build

The annoying behavior where the output is different due to the
legality check struck again, plus the subtarget predicate wasn't
really correctly set for DS FP atomics.

Some of the FP min/max instructions seem to be in the gfx6/gfx7
manuals, but IIRC this might have been one of the cases where the
manual got ahead of the actual hardware support, but I've left these
as-is for now since the assembler tests seem to expect them.




More information about the All-commits mailing list