[all-commits] [llvm/llvm-project] 0d4e24: [WebAssembly] Improve clang diagnostics for wasm a...

[Dan Gohman via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0d4e243456809eabd6914669753eda242b5da4cb
      https://github.com/llvm/llvm-project/commit/0d4e243456809eabd6914669753eda242b5da4cb
  Author: Dan Gohman <sunfish at mozilla.com>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/include/clang/Sema/Sema.h
    M clang/lib/Sema/SemaDecl.cpp
    M clang/lib/Sema/SemaDeclAttr.cpp
    A clang/test/AST/ast-dump-wasm-attr-export.c
    A clang/test/AST/ast-dump-wasm-attr-import.c
    A clang/test/Sema/attr-wasm.c

  Log Message:
  -----------
  [WebAssembly] Improve clang diagnostics for wasm attributes

This patch addresses the review comments on r352930:

 - Removes redundant diagnostic checking code
 - Removes errnoneous use of diag::err_alias_is_definition, which
   turned out to be ineffective anyway since functions can be defined later
   in the translation unit and avoid detection.
 - Adds a test for various invalid cases for import_name and import_module.

This reapplies D59520, with the addition of adding
`InGroup<IgnoredAttributes>` to the new warnings, to fix the
Misc/warning-flags.c failure.

Differential Revision: https://reviews.llvm.org/D59520