[all-commits] [llvm/llvm-project] 399b12: [llvm-ar] Add more tests for errors in opening arc...

[Sameer Arora via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 399b12700b41cd58484c23639e61cace819229f6
      https://github.com/llvm/llvm-project/commit/399b12700b41cd58484c23639e61cace819229f6
  Author: Sameer Arora <sameerarora101 at fb.com>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    A llvm/test/tools/llvm-ar/error-opening-directory.test
    A llvm/test/tools/llvm-ar/error-opening-permission.test

  Log Message:
  -----------
  [llvm-ar] Add more tests for errors in opening archives

Add 2 more tests for the function performOperation under llvm-ar.cpp. It
tests the scenario when the archive could not be opened for reasons
other than `no_such_file_or_directory` In particular, it tests for the
cases `permission_denied` and `is_a_directory` for the target archive.

Reviewed By: alexshap, jhenderson, smeenai, MaskRay

Differential Revision: https://reviews.llvm.org/D80838


  Commit: 99e1b0dc8fbdd35426ac39a98c05718cd482f48a
      https://github.com/llvm/llvm-project/commit/99e1b0dc8fbdd35426ac39a98c05718cd482f48a
  Author: Sameer Arora <sameerarora101 at fb.com>
  Date:   2020-06-05 (Fri, 05 Jun 2020)

  Changed paths:
    M llvm/test/Object/ar-create.test
    M llvm/test/tools/llvm-ar/error-opening-directory.test
    M llvm/test/tools/llvm-ar/error-opening-permission.test
    M llvm/test/tools/llvm-ar/print.test
    M llvm/tools/llvm-ar/llvm-ar.cpp

  Log Message:
  -----------
  [llvm-ar] Update error messages and tests as per latest preferred style

It updates two error messages under `performOperation` in the file
llvm-ar.cpp. Furthermore, it also updates tests that print out these
error messages: `llvm/test/Object/ar-create.test` and
`llvm/test/tools/llvm-ar/print.test`.

Reviewed By: jhenderson, MaskRay

Differential Revision: https://reviews.llvm.org/D80846


Compare: https://github.com/llvm/llvm-project/compare/b56bf30d3cc1...99e1b0dc8fbd