[all-commits] [llvm/llvm-project] d76e62: [AddressSanitizer] Don't use weak linkage for __{s...

[Petr Hosek via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d76e62fdb7a93d9a33f642b6b528f2562cc3c3f4
      https://github.com/llvm/llvm-project/commit/d76e62fdb7a93d9a33f642b6b528f2562cc3c3f4
  Author: Petr Hosek <phosek at google.com>
  Date:   2020-06-04 (Thu, 04 Jun 2020)

  Changed paths:
    M llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata.ll

  Log Message:
  -----------
  [AddressSanitizer] Don't use weak linkage for __{start,stop}_asan_globals

It should not be necessary to use weak linkage for these. Doing so
implies interposablity and thus PIC generates indirections and
dynamic relocations, which are unnecessary and suboptimal. Aside
from this, ASan instrumentation never introduces GOT indirection
relocations where there were none before--only new absolute relocs
in RELRO sections for metadata, which are less problematic for
special linkage situations that take pains to avoid GOT generation.

Patch By: mcgrathr

Differential Revision: https://reviews.llvm.org/D80605