[all-commits] [llvm/llvm-project] c0cd1f: [mlir] Refactor BoolAttr to be a special case of I...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c0cd1f1c5cc97e0c90727b3e4d5f52dd6a7aae55
      https://github.com/llvm/llvm-project/commit/c0cd1f1c5cc97e0c90727b3e4d5f52dd6a7aae55
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-06-04 (Thu, 04 Jun 2020)

  Changed paths:
    M mlir/include/mlir/IR/Attributes.h
    M mlir/lib/Dialect/SCF/SCF.cpp
    M mlir/lib/Dialect/SPIRV/SPIRVOps.cpp
    M mlir/lib/Dialect/SPIRV/Serialization/Serializer.cpp
    M mlir/lib/Dialect/StandardOps/IR/Ops.cpp
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/IR/AttributeDetail.h
    M mlir/lib/IR/Attributes.cpp
    M mlir/lib/IR/Builders.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    M mlir/test/Conversion/SCFToStandard/convert-to-cfg.mlir
    M mlir/test/Conversion/StandardToSPIRV/std-ops-to-spirv.mlir
    M mlir/test/Conversion/VectorToLLVM/vector-to-llvm.mlir
    M mlir/test/Dialect/Standard/canonicalize-cf.mlir
    M mlir/test/Dialect/Vector/vector-contract-transforms.mlir
    M mlir/test/EDSC/builder-api-test.cpp
    M mlir/test/IR/invalid.mlir
    M mlir/test/IR/parser.mlir
    M mlir/test/Target/import.ll
    M mlir/test/Transforms/constant-fold.mlir
    M mlir/test/Transforms/cse.mlir
    M mlir/test/Transforms/inlining.mlir
    M mlir/test/Transforms/sccp-callgraph.mlir
    M mlir/test/Transforms/sccp.mlir

  Log Message:
  -----------
  [mlir] Refactor BoolAttr to be a special case of IntegerAttr

This simplifies a lot of handling of BoolAttr/IntegerAttr. For example, a lot of places currently have to handle both IntegerAttr and BoolAttr. In other places, a decision is made to pick one which can lead to surprising results for users. For example, DenseElementsAttr currently uses BoolAttr for i1 even if the user initialized it with an Array of i1 IntegerAttrs.

Differential Revision: https://reviews.llvm.org/D81047