[all-commits] [llvm/llvm-project] bd43f7: [LSR][SCEVExpander] Avoid blind cast 'Factor' to S...

[huihzhang via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bd43f78c76632a5c19745e5db2d02c2806c66bfe
      https://github.com/llvm/llvm-project/commit/bd43f78c76632a5c19745e5db2d02c2806c66bfe
  Author: Huihui Zhang <huihuiz at quicinc.com>
  Date:   2020-06-04 (Thu, 04 Jun 2020)

  Changed paths:
    M llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp
    A llvm/test/Transforms/LoopStrengthReduce/vscale-factor-out-constant.ll

  Log Message:
  -----------
  [LSR][SCEVExpander] Avoid blind cast 'Factor' to SCEVConstant in FactorOutConstant.

Summary:
In SCEVExpander FactorOutConstant(), when GEP indexing into/over scalable vector,
it is legal for the 'Factor' in a MulExpr to be the size of a scalable vector
instead of a compile-time constant.

Current upstream crash with the test attached.

Reviewers: efriedma, sdesmalen, sanjoy.google, mkazantsev

Reviewed By: efriedma

Subscribers: hiraditya, javed.absar, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80973