[all-commits] [llvm/llvm-project] 87e24c: Revert "[DAGCombiner] avoid unnecessary indirectio...

Tim Northover via All-commits all-commits at lists.llvm.org
Thu Jun 4 03:53:46 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 87e24c3200895ac086d83b780c90ce85669e7df1
      https://github.com/llvm/llvm-project/commit/87e24c3200895ac086d83b780c90ce85669e7df1
  Author: Tim Northover <t.p.northover at gmail.com>
  Date:   2020-06-04 (Thu, 04 Jun 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

  Log Message:
  -----------
  Revert "[DAGCombiner] avoid unnecessary indirection from SDNode/SDValue; NFCI"

This reverts commit 21dadd774f56778ef68c1ce307205dfbdacc793a.

In at least PromoteIntBinOps, they wanted to know about users of *all* values
produced by the node not just the integer being promoted. For example not
replacing chain users if the operation was a load breaks the ordering of the
DAG.




More information about the All-commits mailing list