[all-commits] [llvm/llvm-project] f5415f: [XCOFF][AIX] Use 'L..' instead of 'L' for PrivateG...

jasonliudev via All-commits all-commits at lists.llvm.org
Wed Jun 3 10:18:54 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f5415f7c5a06e8563c650a3ecfd6435d36ca3a66
      https://github.com/llvm/llvm-project/commit/f5415f7c5a06e8563c650a3ecfd6435d36ca3a66
  Author: jasonliu <jasonliu.development at gmail.com>
  Date:   2020-06-03 (Wed, 03 Jun 2020)

  Changed paths:
    M llvm/lib/MC/MCAsmInfoXCOFF.cpp
    M llvm/test/CodeGen/PowerPC/aix-cc-abi.ll
    M llvm/test/CodeGen/PowerPC/aix-cc-byval-mem.ll
    M llvm/test/CodeGen/PowerPC/aix-cc-byval.ll
    M llvm/test/CodeGen/PowerPC/aix-extern-weak.ll
    M llvm/test/CodeGen/PowerPC/aix-extern.ll
    M llvm/test/CodeGen/PowerPC/aix-lower-block-address.ll
    M llvm/test/CodeGen/PowerPC/aix-lower-constant-pool-index.ll
    M llvm/test/CodeGen/PowerPC/aix-lower-jump-table.ll
    M llvm/test/CodeGen/PowerPC/aix-weak.ll
    A llvm/test/CodeGen/PowerPC/aix-xcoff-externL.ll
    M llvm/test/CodeGen/PowerPC/aix-xcoff-toc.ll
    M llvm/test/CodeGen/PowerPC/aix64-cc-byval.ll
    M llvm/test/CodeGen/PowerPC/lower-globaladdr32-aix-asm.ll
    M llvm/test/CodeGen/PowerPC/lower-globaladdr64-aix-asm.ll

  Log Message:
  -----------
  [XCOFF][AIX] Use 'L..' instead of 'L' for PrivateGlobalPrefix

Without this change, names start with 'L' will get created as
temporary symbol in MCContext::createSymbol.

Some other potential prefix considered:
.L, does not work for AIX, as a function start with L will end
up with .L as prefix for its function entry point.

..L could work, but it does not play well with the convention
on AIX that anything start with '.' are considered as entry point.

L. could work, but not sure if it's safe enough, as it's possible
to have suffixes like .something append to a plain L, giving L.something
which is not necessarily a temporary.

That's why we picked L.. for now.

Differential Revision: https://reviews.llvm.org/D80831




More information about the All-commits mailing list