[all-commits] [llvm/llvm-project] d20fdc: [AIX] Update data directives for AIX assembly

David Tenty via All-commits all-commits at lists.llvm.org
Wed Jun 3 07:56:18 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d20fdcabf82fb30239a3f361950814e39e4c20a8
      https://github.com/llvm/llvm-project/commit/d20fdcabf82fb30239a3f361950814e39e4c20a8
  Author: David Tenty <daltenty at ibm.com>
  Date:   2020-06-03 (Wed, 03 Jun 2020)

  Changed paths:
    M llvm/lib/MC/MCAsmInfoXCOFF.cpp
    M llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp
    M llvm/test/CodeGen/PowerPC/aix-extern-weak.ll
    M llvm/test/CodeGen/PowerPC/aix-extern.ll
    M llvm/test/CodeGen/PowerPC/aix-lower-constant-pool-index.ll
    M llvm/test/CodeGen/PowerPC/aix-lower-jump-table.ll
    M llvm/test/CodeGen/PowerPC/aix-readonly-with-relocation.ll
    M llvm/test/CodeGen/PowerPC/aix-reference-func-addr-const.ll
    M llvm/test/CodeGen/PowerPC/aix-weak.ll
    M llvm/test/CodeGen/PowerPC/aix-xcoff-data.ll
    M llvm/test/CodeGen/PowerPC/aix-xcoff-lower-comm.ll
    M llvm/test/CodeGen/PowerPC/aix-xcoff-mergeable-const.ll
    M llvm/test/CodeGen/PowerPC/aix-xcoff-mergeable-str.ll
    M llvm/test/CodeGen/PowerPC/aix-xcoff-rodata.ll
    M llvm/test/CodeGen/PowerPC/test_func_desc.ll

  Log Message:
  -----------
  [AIX] Update data directives for AIX assembly

Summary:
The standard data emission directives (e.g. .short, .long) in the AIX assembler
have the unintended consequence of aligning their output to the natural byte
boundary. This cause problems because we aren't expecting behavior from the
Data*bitsDirectives, so the final alignment of data isn't correct in some cases
on AIX.

This patch updated the Data*bitsDirectives to use .vbyte pseudo-ops instead to emit the
data, since we will emit the .align directives as needed. We update the existing
testcases and add a test for emission of struct data.

Reviewers: hubert.reinterpretcast, Xiangling_L, jasonliu

Reviewed By: hubert.reinterpretcast, jasonliu

Subscribers: wuzish, nemanjai, hiraditya, kbarton, arphaman, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80934




More information about the All-commits mailing list