[all-commits] [llvm/llvm-project] eaebcb: [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN

Konrad Kleine via All-commits all-commits at lists.llvm.org
Tue Jun 2 10:24:20 PDT 2020 

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: eaebcbc67926a18befaa297f1778edde63baec9b
      https://github.com/llvm/llvm-project/commit/eaebcbc67926a18befaa297f1778edde63baec9b
  Author: Konrad Kleine <kkleine at redhat.com>
  Date:   2020-06-02 (Tue, 02 Jun 2020)

  Changed paths:
    M lldb/examples/interposing/darwin/fd_interposing/FDInterposing.cpp
    M lldb/include/lldb/API/SBCommunication.h
    M lldb/include/lldb/API/SBStream.h
    M lldb/include/lldb/Breakpoint/Breakpoint.h
    M lldb/include/lldb/Breakpoint/BreakpointIDList.h
    M lldb/include/lldb/Breakpoint/BreakpointList.h
    M lldb/include/lldb/Breakpoint/BreakpointLocation.h
    M lldb/include/lldb/Breakpoint/BreakpointResolver.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverAddress.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverFileRegex.h
    M lldb/include/lldb/Breakpoint/BreakpointResolverScripted.h
    M lldb/include/lldb/Breakpoint/BreakpointSite.h
    M lldb/include/lldb/Breakpoint/Stoppoint.h
    M lldb/include/lldb/Breakpoint/StoppointLocation.h
    M lldb/include/lldb/Breakpoint/Watchpoint.h
    M lldb/include/lldb/Core/AddressResolver.h
    M lldb/include/lldb/Core/AddressResolverFileLine.h
    M lldb/include/lldb/Core/AddressResolverName.h
    M lldb/include/lldb/Core/Communication.h
    M lldb/include/lldb/Core/Debugger.h
    M lldb/include/lldb/Core/Disassembler.h
    M lldb/include/lldb/Core/EmulateInstruction.h
    M lldb/include/lldb/Core/FileLineResolver.h
    M lldb/include/lldb/Core/Highlighter.h
    M lldb/include/lldb/Core/IOHandler.h
    M lldb/include/lldb/Core/Module.h
    M lldb/include/lldb/Core/Section.h
    M lldb/include/lldb/Core/SourceManager.h
    M lldb/include/lldb/Core/StreamFile.h
    M lldb/include/lldb/Core/ThreadSafeValue.h
    M lldb/include/lldb/Core/ValueObject.h
    M lldb/include/lldb/Core/ValueObjectCast.h
    M lldb/include/lldb/Core/ValueObjectChild.h
    M lldb/include/lldb/Core/ValueObjectConstResult.h
    M lldb/include/lldb/Core/ValueObjectConstResultCast.h
    M lldb/include/lldb/Core/ValueObjectConstResultChild.h
    M lldb/include/lldb/Core/ValueObjectConstResultImpl.h
    M lldb/include/lldb/Core/ValueObjectDynamicValue.h
    M lldb/include/lldb/Core/ValueObjectMemory.h
    M lldb/include/lldb/Core/ValueObjectRegister.h
    M lldb/include/lldb/Core/ValueObjectSyntheticFilter.h
    M lldb/include/lldb/Core/ValueObjectVariable.h
    M lldb/include/lldb/DataFormatters/FormatClasses.h
    M lldb/include/lldb/DataFormatters/FormattersContainer.h
    M lldb/include/lldb/DataFormatters/TypeFormat.h
    M lldb/include/lldb/DataFormatters/TypeSummary.h
    M lldb/include/lldb/DataFormatters/TypeSynthetic.h
    M lldb/include/lldb/DataFormatters/ValueObjectPrinter.h
    M lldb/include/lldb/Expression/IRMemoryMap.h
    M lldb/include/lldb/Host/File.h
    M lldb/include/lldb/Host/HostNativeProcessBase.h
    M lldb/include/lldb/Host/HostNativeThreadBase.h
    M lldb/include/lldb/Host/MainLoop.h
    M lldb/include/lldb/Host/MainLoopBase.h
    M lldb/include/lldb/Host/ProcessRunLock.h
    M lldb/include/lldb/Host/PseudoTerminal.h
    M lldb/include/lldb/Host/common/NativeRegisterContext.h
    M lldb/include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
    M lldb/include/lldb/Host/posix/HostThreadPosix.h
    M lldb/include/lldb/Host/windows/ConnectionGenericFileWindows.h
    M lldb/include/lldb/Host/windows/HostThreadWindows.h
    M lldb/include/lldb/Interpreter/CommandHistory.h
    M lldb/include/lldb/Interpreter/CommandObjectRegexCommand.h
    M lldb/include/lldb/Interpreter/OptionGroupVariable.h
    M lldb/include/lldb/Interpreter/OptionGroupWatchpoint.h
    M lldb/include/lldb/Interpreter/ScriptInterpreter.h
    M lldb/include/lldb/Symbol/Block.h
    M lldb/include/lldb/Symbol/CompileUnit.h
    M lldb/include/lldb/Symbol/DebugMacros.h
    M lldb/include/lldb/Symbol/DeclVendor.h
    M lldb/include/lldb/Symbol/FuncUnwinders.h
    M lldb/include/lldb/Symbol/Function.h
    M lldb/include/lldb/Symbol/LineTable.h
    M lldb/include/lldb/Symbol/ObjectContainer.h
    M lldb/include/lldb/Symbol/ObjectFile.h
    M lldb/include/lldb/Symbol/SymbolFile.h
    M lldb/include/lldb/Symbol/SymbolVendor.h
    M lldb/include/lldb/Symbol/Symtab.h
    M lldb/include/lldb/Symbol/TypeList.h
    M lldb/include/lldb/Symbol/TypeMap.h
    M lldb/include/lldb/Symbol/UnwindTable.h
    M lldb/include/lldb/Symbol/VariableList.h
    M lldb/include/lldb/Target/ABI.h
    M lldb/include/lldb/Target/DynamicLoader.h
    M lldb/include/lldb/Target/Language.h
    M lldb/include/lldb/Target/LanguageRuntime.h
    M lldb/include/lldb/Target/Memory.h
    M lldb/include/lldb/Target/OperatingSystem.h
    M lldb/include/lldb/Target/Platform.h
    M lldb/include/lldb/Target/Process.h
    M lldb/include/lldb/Target/Queue.h
    M lldb/include/lldb/Target/QueueItem.h
    M lldb/include/lldb/Target/RegisterCheckpoint.h
    M lldb/include/lldb/Target/RegisterContext.h
    M lldb/include/lldb/Target/RegisterContextUnwind.h
    M lldb/include/lldb/Target/SectionLoadHistory.h
    M lldb/include/lldb/Target/StackFrame.h
    M lldb/include/lldb/Target/StackFrameList.h
    M lldb/include/lldb/Target/StackFrameRecognizer.h
    M lldb/include/lldb/Target/StopInfo.h
    M lldb/include/lldb/Target/StructuredDataPlugin.h
    M lldb/include/lldb/Target/SystemRuntime.h
    M lldb/include/lldb/Target/Target.h
    M lldb/include/lldb/Target/TargetList.h
    M lldb/include/lldb/Target/Thread.h
    M lldb/include/lldb/Target/ThreadPlan.h
    M lldb/include/lldb/Target/ThreadPlanBase.h
    M lldb/include/lldb/Target/ThreadPlanCallFunction.h
    M lldb/include/lldb/Target/ThreadPlanCallFunctionUsingABI.h
    M lldb/include/lldb/Target/ThreadPlanCallUserExpression.h
    M lldb/include/lldb/Target/ThreadPlanPython.h
    M lldb/include/lldb/Target/ThreadPlanRunToAddress.h
    M lldb/include/lldb/Target/ThreadPlanShouldStopHere.h
    M lldb/include/lldb/Target/ThreadPlanStepInRange.h
    M lldb/include/lldb/Target/ThreadPlanStepInstruction.h
    M lldb/include/lldb/Target/ThreadPlanStepOut.h
    M lldb/include/lldb/Target/ThreadPlanStepOverBreakpoint.h
    M lldb/include/lldb/Target/ThreadPlanStepOverRange.h
    M lldb/include/lldb/Target/ThreadPlanStepRange.h
    M lldb/include/lldb/Target/ThreadPlanStepThrough.h
    M lldb/include/lldb/Target/ThreadPlanStepUntil.h
    M lldb/include/lldb/Target/Unwind.h
    M lldb/include/lldb/Target/UnwindAssembly.h
    M lldb/include/lldb/Target/UnwindLLDB.h
    M lldb/include/lldb/Utility/Broadcaster.h
    M lldb/include/lldb/Utility/Connection.h
    M lldb/include/lldb/Utility/DataEncoder.h
    M lldb/include/lldb/Utility/Event.h
    M lldb/include/lldb/Utility/IOObject.h
    M lldb/include/lldb/Utility/Listener.h
    M lldb/include/lldb/Utility/Predicate.h
    M lldb/include/lldb/Utility/Timer.h
    M lldb/include/lldb/lldb-defines.h
    M lldb/source/Commands/CommandCompletions.cpp
    M lldb/source/Commands/CommandObjectLog.h
    M lldb/source/Commands/CommandObjectPlatform.cpp
    M lldb/source/Commands/CommandObjectPlatform.h
    M lldb/source/Commands/CommandObjectRegister.h
    M lldb/source/Commands/CommandObjectTarget.cpp
    M lldb/source/Core/IOHandlerCursesGUI.cpp
    M lldb/source/Host/macosx/objcxx/HostThreadMacOSX.mm
    M lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.h
    M lldb/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.h
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.h
    M lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.h
    M lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.h
    M lldb/source/Plugins/DynamicLoader/Static/DynamicLoaderStatic.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangDeclVendor.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionVariable.h
    M lldb/source/Plugins/Instruction/ARM/EmulationStateARM.h
    M lldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h
    M lldb/source/Plugins/LanguageRuntime/ObjC/ObjCLanguageRuntime.h
    M lldb/source/Plugins/Platform/Android/PlatformAndroid.h
    M lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.h
    M lldb/source/Plugins/Platform/FreeBSD/PlatformFreeBSD.h
    M lldb/source/Plugins/Platform/Linux/PlatformLinux.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleTV.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteAppleWatch.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h
    M lldb/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
    M lldb/source/Plugins/Platform/NetBSD/PlatformNetBSD.h
    M lldb/source/Plugins/Platform/OpenBSD/PlatformOpenBSD.h
    M lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.h
    M lldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.h
    M lldb/source/Plugins/Process/MacOSX-Kernel/CommunicationKDP.h
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h
    M lldb/source/Plugins/Process/Utility/RegisterContextDummy.h
    M lldb/source/Plugins/Process/Utility/RegisterContextHistory.h
    M lldb/source/Plugins/Process/Utility/RegisterContextMemory.h
    M lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.h
    M lldb/source/Plugins/Process/Utility/ThreadMemory.h
    M lldb/source/Plugins/Process/elf-core/ProcessElfCore.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationReplayServer.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
    M lldb/source/Plugins/Process/mach-core/ProcessMachCore.h
    M lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
    M lldb/source/Plugins/SymbolFile/Symtab/SymbolFileSymtab.h
    M lldb/source/Plugins/SymbolVendor/ELF/SymbolVendorELF.h
    M lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.h
    M lldb/source/Plugins/SymbolVendor/wasm/SymbolVendorWasm.h
    M lldb/source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.h
    M lldb/source/Plugins/UnwindAssembly/x86/x86AssemblyInspectionEngine.h

  Log Message:
  -----------
  [lldb] NFC remove DISALLOW_COPY_AND_ASSIGN

Summary:
This is how I applied my clang-tidy check (see
https://reviews.llvm.org/D80531) in order to remove
`DISALLOW_COPY_AND_ASSIGN` and have deleted copy ctors and deleted
assignment operators instead.

```
lang=bash
grep DISALLOW_COPY_AND_ASSIGN /opt/notnfs/kkleine/llvm/lldb -r -l | sort | uniq > files

for i in $(cat files);
do
  clang-tidy \
    --checks="-*,modernize-replace-disallow-copy-and-assign-macro" \
    --format-style=LLVM \
    --header-filter=.* \
    --fix \
    -fix-errors \
    $i;
done
```

Reviewers: espindola, labath, aprantl, teemperor

Reviewed By: labath, aprantl, teemperor

Subscribers: teemperor, aprantl, labath, emaste, sbc100, aheejin, MaskRay, arphaman, usaxena95, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D80543

More information about the All-commits mailing list