[all-commits] [llvm/llvm-project] 836c7d: DAG: Fix getNode dropping flags if there's a glue ...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jun 1 11:00:10 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 836c7dcf1238683ff18882affac1dae5ae5c5f79
      https://github.com/llvm/llvm-project/commit/836c7dcf1238683ff18882affac1dae5ae5c5f79
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-06-01 (Mon, 01 Jun 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

  Log Message:
  -----------
  DAG: Fix getNode dropping flags if there's a glue output

The AMDGPU non-strict fdiv lowering needs to introduce an FP mode
switch in some cases, and has custom nodes to provide chain/glue for
the intermediate FP operations. We need to propagate nofpexcept here,
but getNode was dropping the flags.

Adding nofpexcept in the AMDGPU custom lowering is left to a future
patch.

Also fix a second case where flags were dropped, but in this case it
seems it just didn't handle this number of operands.

Test will be included in future AMDGPU patch.




More information about the All-commits mailing list