[all-commits] [llvm/llvm-project] e5b877: [utils] change default nameless value to "TMP"

RotateRight via All-commits all-commits at lists.llvm.org
Mon Jun 1 03:55:06 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6
      https://github.com/llvm/llvm-project/commit/e5b8772756737e41cb1e8ee1a5a33cb3d8a25be6
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-06-01 (Mon, 01 Jun 2020)

  Changed paths:
    M clang/test/utils/update_cc_test_checks/Inputs/mangled_names.c.expected
    M clang/test/utils/update_cc_test_checks/Inputs/mangled_names.c.funcsig.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll.funcsig.expected
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  [utils] change default nameless value to "TMP"

This is effectively reverting rGbfdc2552664d to avoid test churn
while we figure out a better way forward.

We at least salvage the warning on name conflict from that patch
though.

If we change the default string again, we may want to mass update
tests at the same time. Alternatively, we could live with the poor
naming if we change -instnamer.

This also adds a test to LLVM as suggested in the post-commit
review. There's a clang test that is also affected. That seems
like a layering violation, but I have not looked at fixing that yet.

Differential Revision: https://reviews.llvm.org/D80584




More information about the All-commits mailing list