[all-commits] [llvm/llvm-project] bfdc25: [utils] change update_test_checks.py use of 'TMP' ...

RotateRight via All-commits all-commits at lists.llvm.org
Sun May 31 07:48:25 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bfdc2552664d6f0bb332a9c6a115877020f3c1df
      https://github.com/llvm/llvm-project/commit/bfdc2552664d6f0bb332a9c6a115877020f3c1df
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-05-31 (Sun, 31 May 2020)

  Changed paths:
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  [utils] change update_test_checks.py use of 'TMP' value names

As discussed in PR45951:
https://bugs.llvm.org/show_bug.cgi?id=45951

There's a potential name collision between update_test_checks.py and -instnamer
and/or manually-generated IR test files because all of them try to use the
variable name that should never be used: "tmp".

This patch proposes to reduce the odds of collision and adds a warning if we
detect the problem. This will cause regression test churn when regenerating
CHECK lines on existing files.

Differential Revision: https://reviews.llvm.org/D80584




More information about the All-commits mailing list