[all-commits] [llvm/llvm-project] 3eb430: [X86] Factor constant pool comment printing out of...

topperc via All-commits all-commits at lists.llvm.org
Sat May 30 14:02:40 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3eb430d59847b9e0091199cb63a50ab0494711dd
      https://github.com/llvm/llvm-project/commit/3eb430d59847b9e0091199cb63a50ab0494711dd
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86MCInstLower.cpp

  Log Message:
  -----------
  [X86] Factor constant pool comment printing out of the switch in X86AsmPrinter::emitInstruction. NFC

Pull the verbose asm check out of the cases and move it up to
the call of the new function.


  Commit: 16976cb92535b0620f46720fe3be283da904026c
      https://github.com/llvm/llvm-project/commit/16976cb92535b0620f46720fe3be283da904026c
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86MCInstLower.cpp

  Log Message:
  -----------
  [X86] Minor cleanups to addShuffleComments in X86MCInstPrinter.cpp. NFCI

-Replace some ifs that should be impossible with asserts.
-Use X86::AddrDisp and X86::AddrNumOperands to make code more readable
-Use X86II::isKMasked/isKMergeMasked to do some operand skipping to remove or simplify switches


Compare: https://github.com/llvm/llvm-project/compare/0fee91a187d9...16976cb92535


More information about the All-commits mailing list