[all-commits] [llvm/llvm-project] 9d0bfc: [SelectionDAG] ComputeNumSignBits - use Valid Min/...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sat May 30 06:09:52 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d0bfcec8377acc29e8a9983e8343dba8e7e900d
      https://github.com/llvm/llvm-project/commit/9d0bfcec8377acc29e8a9983e8343dba8e7e900d
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

  Log Message:
  -----------
  [SelectionDAG] ComputeNumSignBits - use Valid Min/Max shift amount helpers directly. NFCI.

We are calling getValidShiftAmountConstant first followed by getValidMinimumShiftAmountConstant/getValidMaximumShiftAmountConstant if that failed. But both are used in the same way in ComputeNumSignBits and the Min/Max variants call getValidShiftAmountConstant internally anyhow.


  Commit: 63824ad94778c54c4c17210591448af746d092ad
      https://github.com/llvm/llvm-project/commit/63824ad94778c54c4c17210591448af746d092ad
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-05-30 (Sat, 30 May 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp

  Log Message:
  -----------
  [TargetLowering] SimplifyDemandedBits - remove shift amount clamps from getValidShiftAmountConstant calls. NFC.

getValidShiftAmountConstant only returns a value if the shift amount is in range, so we don't need to check it again.


Compare: https://github.com/llvm/llvm-project/compare/179f8ad08de0...63824ad94778


More information about the All-commits mailing list