[all-commits] [llvm/llvm-project] 03559c: [diagtool] Install diagtool when LLVM_INSTALL_TOOL...

Volodymyr Sapsai via All-commits all-commits at lists.llvm.org
Fri May 29 16:26:16 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3
      https://github.com/llvm/llvm-project/commit/03559c684a9bfe4de142fa4a7d2ef1edf08a8ad3
  Author: Volodymyr Sapsai <vsapsai at apple.com>
  Date:   2020-05-29 (Fri, 29 May 2020)

  Changed paths:
    M clang/tools/diagtool/CMakeLists.txt

  Log Message:
  -----------
  [diagtool] Install diagtool when LLVM_INSTALL_TOOLCHAIN_ONLY is ON.

Not sure about other platforms but `install-xcode-toolchain` was already
including diagtool in the toolchain. This change makes it possible to
install diagtool during Apple's 2-stage build.

Instead of dropping `if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY)` conditional
I've switched to `add_clang_tool` which handles install targets. Also a
few other clang tools like clang-format, clang-scan-deps are using this
macro, so it is good to be consistent.

rdar://problem/15386909

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D80770




More information about the All-commits mailing list