[all-commits] [llvm/llvm-project] 7fc225: [mlir] Fix Windows build

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Fri May 29 15:57:45 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7fc225f8c4596d4e51d64e814b21cc49c5e8566b
      https://github.com/llvm/llvm-project/commit/7fc225f8c4596d4e51d64e814b21cc49c5e8566b
  Author: Nicolas Vasilache <ntv at google.com>
  Date:   2020-05-29 (Fri, 29 May 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h

  Log Message:
  -----------
  [mlir] Fix Windows build

Summary:
MSVC does not seem to like certain forward declarations.

https://reviews.llvm.org/D80728 introduces an error where
seemingly unrelated .cpp files that include the .h
(but do not otherwise use the class that depends on the forward declaration).

Instead of forward declaration, include the full vector ops definition.

Subscribers: mehdi_amini, rriddle, jpienaar, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, stephenneuendorffer, Joonsoo, grosul1, frgossen, Kayjukh, jurahul, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80841




More information about the All-commits mailing list