[all-commits] [llvm/llvm-project] 2c22c1: [lldb] Make "inline" tests more configurable

[Emre Kultursay via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c22c1473569352efa9326aa165cc451d39da015
      https://github.com/llvm/llvm-project/commit/2c22c1473569352efa9326aa165cc451d39da015
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-05-29 (Fri, 29 May 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbinline.py
    R lldb/test/API/functionalities/param_entry_vals/basic_entry_values/Makefile
    M lldb/test/API/functionalities/param_entry_vals/basic_entry_values/TestBasicEntryValues.py

  Log Message:
  -----------
  [lldb] Make "inline" tests more configurable

Summary:
This patch adds two new arguments to the MakeInlineTest function. The
main motivation is a follow-up patch I'm preparing, but they seem
generally useful.

The first argument allows the user to specify the "build dictionary".
With this argument one can avoid the need to provide a custom Makefile
if all he needs is to override a couple of make variables. This hooks in
neatly into the existing dictionary support for non-inline tests.

The second argument specifies the name of the test. This could be used
to provide better names to the generated test classes, but it's mainly
useful in conjuction with the first argument: now that we can specify a
custom build dictionary, it may sometimes make sense to run the same
test twice with different build configurations. To achieve that, we need
to give the two tests different names, and this argument achieves that.

The usage of the arguments is demonstrated via TestBasicEntryValues.py.

Reviewers: vsk, JDevlieghere

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D80518


  Commit: 7ff2de4f0c60c5d13880440e85ef8edc78482a2f
      https://github.com/llvm/llvm-project/commit/7ff2de4f0c60c5d13880440e85ef8edc78482a2f
  Author: Emre Kultursay <emrekultursay at google.com>
  Date:   2020-05-29 (Fri, 29 May 2020)

  Changed paths:
    M lldb/source/Plugins/Platform/Android/AdbClient.cpp
    A lldb/unittests/Platform/Android/AdbClientTest.cpp
    A lldb/unittests/Platform/Android/CMakeLists.txt
    M lldb/unittests/Platform/CMakeLists.txt

  Log Message:
  -----------
  Do not list adb devices when a device id is given

Summary:
On Android, this method gets called twice: first when establishing
a host-server connection, then when attaching to a process id.

Each call takes several seconds to finish (especially slower on Windows)
and eliminating the call for the typical case improves latency significantly.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D79586


Compare: https://github.com/llvm/llvm-project/compare/5f0267984792...7ff2de4f0c60