[all-commits] [llvm/llvm-project] 034812: Refactor argument attribute specification in intri...

[darkbuck via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 03481287ca530494512d128cbbdc9c87f2d84921
      https://github.com/llvm/llvm-project/commit/03481287ca530494512d128cbbdc9c87f2d84921
  Author: Michael Liao <michael.hliao at gmail.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M llvm/include/llvm/IR/Intrinsics.td
    M llvm/include/llvm/IR/IntrinsicsAArch64.td
    M llvm/include/llvm/IR/IntrinsicsAMDGPU.td
    M llvm/include/llvm/IR/IntrinsicsARM.td
    M llvm/include/llvm/IR/IntrinsicsBPF.td
    M llvm/include/llvm/IR/IntrinsicsHexagon.td
    M llvm/include/llvm/IR/IntrinsicsHexagonDep.td
    M llvm/include/llvm/IR/IntrinsicsMips.td
    M llvm/include/llvm/IR/IntrinsicsNVVM.td
    M llvm/include/llvm/IR/IntrinsicsPowerPC.td
    M llvm/include/llvm/IR/IntrinsicsRISCV.td
    M llvm/include/llvm/IR/IntrinsicsSystemZ.td
    M llvm/include/llvm/IR/IntrinsicsWebAssembly.td
    M llvm/include/llvm/IR/IntrinsicsX86.td
    M llvm/include/llvm/IR/IntrinsicsXCore.td
    M llvm/test/TableGen/GlobalISelEmitter-SDNodeXForm-timm.td
    M llvm/test/TableGen/GlobalISelEmitter-immarg-literal-pattern.td
    M llvm/test/TableGen/immarg.td
    M llvm/utils/TableGen/CodeGenIntrinsics.h
    M llvm/utils/TableGen/CodeGenTarget.cpp
    M llvm/utils/TableGen/IntrinsicEmitter.cpp

  Log Message:
  -----------
  Refactor argument attribute specification in intrinsic definition. NFC.

- Argument attribute needs specifiying through `ArgIndex<n>`
  (corresponding to `FirstArgIndex`) to distinguish explicitly from the
  index number from the overloaded type list.
- In addition, `RetIndex` (corresponding to `ReturnIndex`) and
  `FuncIndex` (corresponding to `FunctionIndex`) are introduced for us
  to associate attributes on the return value and potentially function
  itself.

Differential Revision: https://reviews.llvm.org/D80422


  Commit: fa342b5c8054dad4cfd1032ac580d71f0f4943d3
      https://github.com/llvm/llvm-project/commit/fa342b5c8054dad4cfd1032ac580d71f0f4943d3
  Author: Michael Liao <michael.hliao at gmail.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M llvm/include/llvm/IR/Attributes.h
    M llvm/include/llvm/IR/Intrinsics.td
    M llvm/include/llvm/IR/IntrinsicsAMDGPU.td
    M llvm/lib/IR/Attributes.cpp
    M llvm/test/CodeGen/AMDGPU/reqd-work-group-size.ll
    M llvm/utils/TableGen/CodeGenIntrinsics.h
    M llvm/utils/TableGen/CodeGenTarget.cpp
    M llvm/utils/TableGen/IntrinsicEmitter.cpp

  Log Message:
  -----------
  Enable `align <n>` to be used in the intrinsic definition.

- This allow us to specify the (minimal) alignment on an intrinsic's
  arguments and, more importantly, the return value.

Differential Revision: https://reviews.llvm.org/D80422


Compare: https://github.com/llvm/llvm-project/compare/804a39a20156...fa342b5c8054