[all-commits] [llvm/llvm-project] 2d0389: Revert "[LAA] We only need pointer checks if there...

Florian Hahn via All-commits all-commits at lists.llvm.org
Wed May 27 04:48:41 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d0389821e0c6371823198d3a5b1f032138a40bb
      https://github.com/llvm/llvm-project/commit/2d0389821e0c6371823198d3a5b1f032138a40bb
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

  Log Message:
  -----------
  Revert "[LAA] We only need pointer checks if there are non-zero checks (NFC)."

This reverts commit 259abfc7cbc11cd98c05b1eb8e4b3fb6a9664bc0.

Reverting this, as I missed a case where we return without setting
RtCheck.Need.


  Commit: 9b507b2127f116f29437e04a187cdca70ae9aa33
      https://github.com/llvm/llvm-project/commit/9b507b2127f116f29437e04a187cdca70ae9aa33
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp

  Log Message:
  -----------
  [LAA] We only need pointer checks if there are non-zero checks (NFC).

If it turns out that we can do runtime checks, but there are no
runtime-checks to generate, set RtCheck.Need to false.

This can happen if we can prove statically that the pointers passed in
to canCheckPtrAtRT do not alias. This should not change any results, but
allows us to skip some work and assert that runtime checks are
generated, if LAA indicates that runtime checks are required.

Reviewers: anemet, Ayal

Reviewed By: Ayal

Differential Revision: https://reviews.llvm.org/D79969

Note: This is a recommit of 259abfc7cbc11cd98c05b1eb8e4b3fb6a9664bc0,
with some suggested renaming.


Compare: https://github.com/llvm/llvm-project/compare/259abfc7cbc1...9b507b2127f1


More information about the All-commits mailing list