[all-commits] [llvm/llvm-project] 519278: [analyzer][RetainCount] Tie diagnostics to osx.coc...

[Kristóf Umann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5192783bb29c32196f87044de113fc43d7dfaae8
      https://github.com/llvm/llvm-project/commit/5192783bb29c32196f87044de113fc43d7dfaae8
  Author: Kirstóf Umann <dkszelethus at gmail.com>
  Date:   2020-05-27 (Wed, 27 May 2020)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp
    M clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h
    M clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp
    M clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.h
    M clang/test/Analysis/Inputs/expected-plists/edges-new.mm.plist
    M clang/test/Analysis/Inputs/expected-plists/objc-arc.m.plist
    M clang/test/Analysis/Inputs/expected-plists/objc-radar17039661.m.plist
    M clang/test/Analysis/Inputs/expected-plists/plist-output-alternate.m.plist
    M clang/test/Analysis/Inputs/expected-plists/plist-output.m.plist
    M clang/test/Analysis/Inputs/expected-plists/retain-release-path-notes.m.plist
    M clang/test/Analysis/Inputs/expected-plists/retain-release.m.objc.plist
    M clang/test/Analysis/Inputs/expected-plists/retain-release.m.objcpp.plist
    M clang/test/Analysis/incorrect-checker-names.mm
    M clang/test/Analysis/inlining/Inputs/expected-plists/path-notes.m.plist
    M clang/test/Analysis/test-separate-retaincount.cpp

  Log Message:
  -----------
  [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

Similarly to other patches of mine, I'm trying to uniformize the checker
interface so that dependency checkers don't emit diagnostics. The checker that
made me most anxious so far was definitely RetainCount, because it is definitely
impacted by backward compatibility concerns, and implements a checker hierarchy
that is a lot different to other examples of similar size. Also, I don't have
authority, nor expertise regarding ObjC related code, so I welcome any
objection/discussion!

Differential Revision: https://reviews.llvm.org/D78099