[all-commits] [llvm/llvm-project] c4dbe5: [flang] Fixes for problems with declaring procedur...

[Pete Steinfeld via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c4dbe59ae8253d73b63e5fcce0bc8bc44b4d07b5
      https://github.com/llvm/llvm-project/commit/c4dbe59ae8253d73b63e5fcce0bc8bc44b4d07b5
  Author: Pete Steinfeld <psteinfeld at nvidia.com>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M flang/include/flang/Semantics/symbol.h
    M flang/lib/Semantics/resolve-names.cpp
    A flang/test/Semantics/resolve91.f90

  Log Message:
  -----------
  [flang] Fixes for problems with declaring procedure entities

Summary:
We were not detecting declaring multiple interfaces to the same procedure.
Also, we were not handling the initialization of entitiies where the associated
Symbol had previously had errors.

I added the function `IsInterfaceSet()` to ProcEntityDetails to see if
the value of `interface_` had been previously set.  I then checked  this
function before calling set_interface() and emitted an error message if
the interface was already set.

Also, in situations where we were emitting error messages for symbols, I
set the Error flag on the Symbol.  Then when performing initialization
on the Symbol, I first check to see if the Symbol had an error.

Reviewers: tskeith, klausler, DavidTruby

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80453