[all-commits] [llvm/llvm-project] 50d4b2: AMDGPU/GlobalISel: Fix assert on 16-bit G_EXTRACT ...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue May 26 09:14:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 50d4b22ca0dd8f25a2ab2cb53a04627b2504ecfe
      https://github.com/llvm/llvm-project/commit/50d4b22ca0dd8f25a2ab2cb53a04627b2504ecfe
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-05-26 (Tue, 26 May 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-extract.mir
    A llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-insert.xfail.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Fix assert on 16-bit G_EXTRACT results

I consider this to be a hack, since we probably should not mark any
16-bit extract as legal, and require all extracts to be done on
multiples of 32. There are quite a few more battles to fight in the
legalizer for sub-dword vectors, so just select this for now so we can
pass OpenCL conformance without crashing.

Also fix the same assert for G_INSERTs. Unlike G_EXTRACT there's not a
trivial way to select this so just fail on it.




More information about the All-commits mailing list