[all-commits] [llvm/llvm-project] 4b8632: [mlir] Expand operand adapter to take attributes

[Jacques Pienaar via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b8632e174d5ba79c4858a1245b96efd3ed281fb
      https://github.com/llvm/llvm-project/commit/4b8632e174d5ba79c4858a1245b96efd3ed281fb
  Author: Jacques Pienaar <jpienaar at google.com>
  Date:   2020-05-24 (Sun, 24 May 2020)

  Changed paths:
    M mlir/include/mlir/TableGen/OpClass.h
    M mlir/lib/TableGen/OpClass.cpp
    M mlir/test/mlir-tblgen/op-decl.td
    M mlir/test/mlir-tblgen/op-operand.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir] Expand operand adapter to take attributes

* Enables using with more variadic sized operands;
* Generate convenience accessors for attributes;
  - The accessor are named the same as their name in ODS and returns attribute
    type (not convenience type) and no derived attributes.

This is first step to changing adapter to support verifying argument
constraints before the op is even created. This does not change the name of
adaptor nor does it require it except for ops with variadic operands to keep this change smaller.

Considered creating separate adapter but decided against that given operands also require attributes in general (and definitely for verification of operands and attributes).

Differential Revision: https://reviews.llvm.org/D80420