[all-commits] [llvm/llvm-project] ef2103: [lit] GoogleTest framework should report failures ...

stephenneuendorffer via All-commits all-commits at lists.llvm.org
Wed May 20 13:42:31 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ef2103182244c96f5206b02164b62b9c9e0cbce8
      https://github.com/llvm/llvm-project/commit/ef2103182244c96f5206b02164b62b9c9e0cbce8
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M llvm/utils/lit/lit/formats/googletest.py
    A llvm/utils/lit/tests/Inputs/googletest-discovery-failed/lit.cfg
    A llvm/utils/lit/tests/Inputs/googletest-discovery-failed/subdir/OneTest.py
    A llvm/utils/lit/tests/googletest-discovery-failed.py

  Log Message:
  -----------
  [lit] GoogleTest framework should report failures if test binary crashes

lit runs a gtest executable multiple times. First it runs it to
discover tests, then later it runs the executable again for each test.
However, if the discovery fails (perhaps because of a broken
executable), then no tests were previously run and no failures were
reported.  This patch creates a dummy test if discovery fails, which
will later fail when test are run and be reported as a failure.

Differential Revision: https://reviews.llvm.org/D80096




More information about the All-commits mailing list