[all-commits] [llvm/llvm-project] bc1c36: Give microsoftDemangle() an outparam for how many ...

Nico Weber via All-commits all-commits at lists.llvm.org
Wed May 20 13:18:24 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bc1c3655bfd67a0b4ccece465729c39d769e9707
      https://github.com/llvm/llvm-project/commit/bc1c3655bfd67a0b4ccece465729c39d769e9707
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M lldb/source/Core/Mangled.cpp
    M llvm/include/llvm/Demangle/Demangle.h
    M llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
    M llvm/lib/Demangle/Demangle.cpp
    M llvm/lib/Demangle/MicrosoftDemangle.cpp
    A llvm/test/Demangle/warn-trailing.test
    M llvm/tools/llvm-microsoft-demangle-fuzzer/llvm-microsoft-demangle-fuzzer.cpp
    M llvm/tools/llvm-objdump/COFFDump.cpp
    M llvm/tools/llvm-undname/llvm-undname.cpp

  Log Message:
  -----------
  Give microsoftDemangle() an outparam for how many input bytes were consumed.

Demangling Itanium symbols either consumes the whole input or fails,
but Microsoft symbols can be successfully demangled with just some
of the input.

Add an outparam that enables clients to know how much of the input was
consumed, and use this flag to give llvm-undname an opt-in warning
on partially consumed symbols.

Differential Revision: https://reviews.llvm.org/D80173




More information about the All-commits mailing list