[all-commits] [llvm/llvm-project] 79fcd3: Revert "[lldb/test] Move "DataFormatters/Mock.h" t...

[Dmitri Gribenko via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 79fcd35c688b94becadd162a6c37e9b95df5c084
      https://github.com/llvm/llvm-project/commit/79fcd35c688b94becadd162a6c37e9b95df5c084
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    A lldb/include/lldb/DataFormatters/Mock.h
    M lldb/source/Plugins/Language/ObjC/Cocoa.cpp
    R lldb/source/Plugins/Language/ObjC/Utilities.h
    M lldb/unittests/DataFormatter/CMakeLists.txt
    A lldb/unittests/DataFormatter/MockTests.cpp
    M lldb/unittests/Language/CMakeLists.txt
    R lldb/unittests/Language/ObjC/CMakeLists.txt
    R lldb/unittests/Language/ObjC/UtilitiesTests.cpp

  Log Message:
  -----------
  Revert "[lldb/test] Move "DataFormatters/Mock.h" to "Plugins/Language/ObjC/Utilities.h""

This reverts commit 82dbf4aca84ec889d0dc390674ff44e30441bcfd. It is a
follow-up to b783f70a42575a5d9147bea1ac97e872370fe55b, which I'm
reverting -- see the explanation in that revert.


  Commit: 23f29b2fcc5668c51f15809067a1c3503b422c64
      https://github.com/llvm/llvm-project/commit/23f29b2fcc5668c51f15809067a1c3503b422c64
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M lldb/source/Plugins/Language/ObjC/Cocoa.cpp
    M lldb/unittests/DataFormatter/MockTests.cpp

  Log Message:
  -----------
  Revert "Silence warnings around int/float conversions."

This reverts commit 15ee8a3a58223b48afbe33cb60084f864ef20889. It is a
follow-up to b783f70a42575a5d9147bea1ac97e872370fe55b, which I'm
reverting -- see the explanation in that revert.


  Commit: f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45
      https://github.com/llvm/llvm-project/commit/f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M lldb/unittests/DataFormatter/MockTests.cpp

  Log Message:
  -----------
  Revert "[lldb/test] Disable NSDate format check under _WIN32"

This reverts commit e3aa4cd9dbcee6441f51102e3958c35321698c67. It is a
follow-up to b783f70a42575a5d9147bea1ac97e872370fe55b, which I'm
reverting -- see the explanation in that revert.


  Commit: 0f1195a58648998d21bcfa1575a78a4706eaa52c
      https://github.com/llvm/llvm-project/commit/0f1195a58648998d21bcfa1575a78a4706eaa52c
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    M lldb/unittests/DataFormatter/MockTests.cpp

  Log Message:
  -----------
  Revert "[lldb/test] Relax NSDate mock test for non-Apple platforms"

This reverts commit fff3a8464d4d518c7086c928fba967908eb294d7. It is a
follow-up to b783f70a42575a5d9147bea1ac97e872370fe55b, which I'm
reverting -- see the explanation in that revert.


  Commit: 8214eff467f583309e9fbb971862d3c1cdcc65e4
      https://github.com/llvm/llvm-project/commit/8214eff467f583309e9fbb971862d3c1cdcc65e4
  Author: Dmitri Gribenko <gribozavr at gmail.com>
  Date:   2020-05-20 (Wed, 20 May 2020)

  Changed paths:
    R lldb/include/lldb/DataFormatters/Mock.h
    M lldb/source/Plugins/Language/ObjC/Cocoa.cpp
    M lldb/unittests/DataFormatter/CMakeLists.txt
    R lldb/unittests/DataFormatter/MockTests.cpp

  Log Message:
  -----------
  Revert "[lldb/DataFormatter] Check for overflow when finding NSDate epoch"

This reverts commit b783f70a42575a5d9147bea1ac97e872370fe55b. This
change had multiple issues which required post-commit fixups, and not
all issues are fixed yet. In particular, the LLDB build bot for ARM is
still broken. There is also an ongoing conversation in the original
phabricator review about whether there is undefined behavior in the
code.


Compare: https://github.com/llvm/llvm-project/compare/baf322598721...8214eff467f5