[all-commits] [llvm/llvm-project] 268fa4: [analyzer] Don't print the config count in debug.C...

Kristóf Umann via All-commits all-commits at lists.llvm.org
Tue May 19 07:51:38 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 268fa40daa151d3b4bff1df12b62e5dae94685d7
      https://github.com/llvm/llvm-project/commit/268fa40daa151d3b4bff1df12b62e5dae94685d7
  Author: Kirstóf Umann <dkszelethus at gmail.com>
  Date:   2020-05-19 (Tue, 19 May 2020)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
    M clang/test/Analysis/analyzer-config.c

  Log Message:
  -----------
  [analyzer] Don't print the config count in debug.ConfigDumper

I think anyone who added a checker config wondered why is there a need
to test this. Its just a chore when adding a new config, so I removed
it.

To give some historic insight though, we used to not list **all**
options, but only those explicitly added to AnalyzerOptions, such as the
ones specified on the command line. However, past this change (and
arguably even before that) this line makes little sense.

There is an argument to be made against the entirety of
analyzer-config.c test file, but since this commit fixes some builtbots
and is landing without review, I wouldn't like to be too invasive.




More information about the All-commits mailing list