[all-commits] [llvm/llvm-project] c9f632: Fix several places that were calling verifyFunctio...

topperc via All-commits all-commits at lists.llvm.org
Mon May 18 13:29:26 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c9f63297e24a1b29c2236ac2e2d1afd96b83114e
      https://github.com/llvm/llvm-project/commit/c9f63297e24a1b29c2236ac2e2d1afd96b83114e
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M llvm/lib/CodeGen/WinEHPrepare.cpp
    M llvm/lib/Target/Hexagon/HexagonCommonGEP.cpp
    M llvm/lib/Transforms/Coroutines/CoroSplit.cpp
    M llvm/lib/Transforms/Vectorize/LoopVectorize.cpp
    M llvm/tools/llvm-as-fuzzer/llvm-as-fuzzer.cpp
    M llvm/tools/llvm-split/llvm-split.cpp

  Log Message:
  -----------
  Fix several places that were calling verifyFunction or verifyModule without checking the return value.

verifyFunction/verifyModule don't assert or error internally. They
also don't print anything if you don't pass a raw_ostream to them.
So the caller needs to check the result and ideally pass a stream
to get the messages. Otherwise they're just really expensive no-ops.

I've filed PR45965 for another instance in SLPVectorizer
that causes a lit test failure.

Differential Revision: https://reviews.llvm.org/D80106




More information about the All-commits mailing list