[all-commits] [llvm/llvm-project] bdd8c1: [IR] Revert r2694 in BasicBlock::removePredecessor

[jayfoad via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bdd8c111fc0d880eec57db860249f1707eed6982
      https://github.com/llvm/llvm-project/commit/bdd8c111fc0d880eec57db860249f1707eed6982
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M llvm/lib/IR/BasicBlock.cpp

  Log Message:
  -----------
  [IR] Revert r2694 in BasicBlock::removePredecessor

r2694 fixed a bug where removePredecessor could create IR with a use not
dominated by its def in a self loop. But this could only happen in an
unreachable loop, and since that time the rules have been relaxed so
that defs don't have to dominate uses in unreachable code, so the fix is
unnecessary. The regression test added in r2691 still stands.

Differential Revision: https://reviews.llvm.org/D80128