[all-commits] [llvm/llvm-project] 87b235: Turn -Wmax-tokens off by default

[Hans via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 87b235db63a3d8d5b82d60ef6202b92b94a7d9d2
      https://github.com/llvm/llvm-project/commit/87b235db63a3d8d5b82d60ef6202b92b94a7d9d2
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticGroups.td
    M clang/include/clang/Basic/DiagnosticParseKinds.td
    M clang/test/Parser/max-tokens.cpp

  Log Message:
  -----------
  Turn -Wmax-tokens off by default

On the one hand, one might interpret the use of the max-token pragmas or
-fmax-tokens flag as an opt-in to the warning. However, in Chromium
we've found it useful to only opt in selected build configurations, even
though we have the pragmas in the code. For that reason, we think it
makes sense to turn it off by default.

Differential revision: https://reviews.llvm.org/D80014