[all-commits] [llvm/llvm-project] 525a59: Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit ...

[Hans via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 525a591f0f48b9d54018bf5245f2abee09c9c1c8
      https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2020-05-18 (Mon, 18 May 2020)

  Changed paths:
    M lldb/test/Shell/SymbolFile/PDB/variables.test
    M llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
    M llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
    M llvm/test/DebugInfo/COFF/global-constants.ll
    M llvm/test/DebugInfo/COFF/global_visibility.ll
    M llvm/test/DebugInfo/COFF/globals.ll
    M llvm/test/DebugInfo/COFF/types-array-unsized.ll

  Log Message:
  -----------
  Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for globals"

> Before this patch, S_[L|G][THREAD32|DATA32] records were emitted with a simple name, not the fully qualified name (namespace + class scope).
>
> Differential Revision: https://reviews.llvm.org/D79447

This causes asserts in Chromium builds:

CodeViewDebug.cpp:2997: void llvm::CodeViewDebug::emitDebugInfoForUDTs(const std::vector<std::pair<std::string, const DIType *>> &):
Assertion `OriginalSize == UDTs.size()' failed.

I will follow up on the Phabricator issue.