[all-commits] [llvm/llvm-project] 0c2c6f: [test] Improve FileCheck's numeric-expression.txt

RoboTux via All-commits all-commits at lists.llvm.org
Fri May 15 16:12:08 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c2c6fce07e43b90e2bc44004710e10192ab3b83
      https://github.com/llvm/llvm-project/commit/0c2c6fce07e43b90e2bc44004710e10192ab3b83
  Author: Thomas Preud'homme <thomasp at graphcore.ai>
  Date:   2020-05-16 (Sat, 16 May 2020)

  Changed paths:
    M llvm/test/FileCheck/numeric-expression.txt

  Log Message:
  -----------
  [test] Improve FileCheck's numeric-expression.txt

Summary:
Various improvement for FileCheck's numeric-expression.txt test:
- remove unused values in USE DEF FMT IMPL MATCH section
- replace 14 literal for 0xe and 0xE to have example of hex literals
- rename variable to be more self-descriptive
- move CHECK as comment of the values being matched to help readability
- add conversion tests
- simplify test for use of several numeric variables by using existing
  variable
- adjust position of error message check to match the alignment of the
  error message wrt. the output matched by the previous check

Reviewed By: jhenderson, jdenny

Differential Revision: https://reviews.llvm.org/D79820




More information about the All-commits mailing list