[all-commits] [llvm/llvm-project] 634a0a: Cleanup some test issues:

Casey Carter via All-commits all-commits at lists.llvm.org
Fri May 15 15:16:11 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 634a0acb307ddad21c5542dc313e02b4df9b216e
      https://github.com/llvm/llvm-project/commit/634a0acb307ddad21c5542dc313e02b4df9b216e
  Author: Casey Carter <Casey at Carter.net>
  Date:   2020-05-15 (Fri, 15 May 2020)

  Changed paths:
    M libcxx/test/std/containers/views/span.cons/stdarray.pass.cpp
    M libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/F_assign.pass.cpp
    M libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/shared_ptr_pointer.pass.cpp

  Log Message:
  -----------
  Cleanup some test issues:

* improve coverage in `span`'s "conversion from `std::array`" test, while eliminating MSVC diagnostics about `testConstructorArray<T>() && testConstructorArray<const T, T>()` being redundant when `T` is already `const`.

* Remove use of `is_assignable` that triggers UB due to an insufficiently-complete type argument in `std::function`'s assignment operator test.

* Don't test that `shared_ptr` initialization from an rvalue triggers the lvalue aliasing constructor on non-libc++; this is not the case for Standard Libraries that implement LWG-2996. (Ditto, I'd simply remove this but it's your library ;).)

Differential Revision: https://reviews.llvm.org/D80030




More information about the All-commits mailing list