[all-commits] [llvm/llvm-project] e9802a: Revert "Run Coverage pass before other *San passes...

Leonard Chan via All-commits all-commits at lists.llvm.org
Thu May 14 15:22:46 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e9802aa4221ba3857041c2328639ce2aac0ace67
      https://github.com/llvm/llvm-project/commit/e9802aa4221ba3857041c2328639ce2aac0ace67
  Author: Leonard Chan <leonardchan at google.com>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M clang/lib/CodeGen/BackendUtil.cpp

  Log Message:
  -----------
  Revert "Run Coverage pass before other *San passes under new pass manager"

This reverts commit 7d5bb94d78386e4653535c35d3e8258bf4502340.

Reverting since this leads to a linker error we're seeing on Fuchsia.
The underlying issue seems to be that inlining is run after sanitizers
and causes different comdat groups instrumented by Sancov to reference
non-key symbols defined in other comdat groups.

Will re-land this patch after a fix for that is landed.




More information about the All-commits mailing list