[all-commits] [llvm/llvm-project] 44ecaa: [BitcodeReader] datalayout must be specified befor...

Eli Friedman via All-commits all-commits at lists.llvm.org
Thu May 14 12:46:17 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 44ecaabc0729fb75fcfec1d46a6bef6bc7c9e1e1
      https://github.com/llvm/llvm-project/commit/44ecaabc0729fb75fcfec1d46a6bef6bc7c9e1e1
  Author: Eli Friedman <efriedma at quicinc.com>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M llvm/lib/Bitcode/Reader/BitcodeReader.cpp

  Log Message:
  -----------
  [BitcodeReader] datalayout must be specified before it is queried.

This isn't really a new invariant; it effectively already existed due to
existing DataLayout queries.  But this makes it explicit.

This is technically not backward-compatible with the existing bitcode
reader, but it's backward-compatible with the output of the bitcode
writer, which is what matters in practice.

No testcase because I don't know a good way to write one: there are no
existing tools that can generate a bitcode file that would trigger the
error.

Split off from D78403.

Differential Revision: https://reviews.llvm.org/D79900




More information about the All-commits mailing list