[all-commits] [llvm/llvm-project] 631048: Moving executable module symbols parsing to target...

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 631048e8117864c09672e33eb7b6fcc4efe5f749
      https://github.com/llvm/llvm-project/commit/631048e8117864c09672e33eb7b6fcc4efe5f749
  Author: Levon Ter-Grigoryan <patriosthegreat at protonmail.ch>
  Date:   2020-05-14 (Thu, 14 May 2020)

  Changed paths:
    M lldb/source/Target/RemoteAwarePlatform.cpp
    M lldb/source/Target/TargetList.cpp
    M lldb/unittests/Target/CMakeLists.txt
    A lldb/unittests/Target/RemoteAwarePlatformTest.cpp

  Log Message:
  -----------
  Moving executable module symbols parsing to target creation method.

Summary:
In our project we are using remote client-server LLDB configuration.
We want to parse as much debugging symbols as we can before debugger starts attachment to the remote process.
To do that we are passing the path of the local executable module to CreateTarget method at the client.
But, it seems that this method are not parsing the executable module symbols.
To fix this I added PreloadSymbols call for executable module to target creation method.

This patch also fixes a problem where the DynamicLoader would reset a
module when launching the target. We fix it by making sure
Platform::ResolveExecutable returns the module object obtained from the
remote platform.

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D78654