[all-commits] [llvm/llvm-project] 479854: [X86] Make the if statement structure for inline a...

topperc via All-commits all-commits at lists.llvm.org
Wed May 13 12:20:25 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 47985451edeb1a6de560dfcae031093bc5eb0f9f
      https://github.com/llvm/llvm-project/commit/47985451edeb1a6de560dfcae031093bc5eb0f9f
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Make the if statement structure for inline assembly constraints 'l', 'r', 'q', 'Q', and 'R' the same.

These did similar things but had slight differences. For example
'Q' didn't allow f64, but the others did.


  Commit: 38e0ab2f3a3dc03acba37efe311c7c0a66665b79
      https://github.com/llvm/llvm-project/commit/38e0ab2f3a3dc03acba37efe311c7c0a66665b79
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/test/CodeGen/X86/asm-reject-reg-type-mismatch.ll

  Log Message:
  -----------
  [X86] Don't allow f80 to be used with the 'q', 'r', 'l', 'Q' or 'q' inline assembly constraints.

It was previously trying to use the 64-bit class, but 80 isn't
evenly divisible by 64 so it will trigger a crash.


Compare: https://github.com/llvm/llvm-project/compare/5435c5def24e...38e0ab2f3a3d


More information about the All-commits mailing list