[all-commits] [llvm/llvm-project] 064e99: [lld][WebAssembly] Fix for --relocatable and signa...

Sam Clegg via All-commits all-commits at lists.llvm.org
Wed May 13 10:28:16 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 064e9907ba069392427887405481d5e7abc1f662
      https://github.com/llvm/llvm-project/commit/064e9907ba069392427887405481d5e7abc1f662
  Author: Sam Clegg <sbc at chromium.org>
  Date:   2020-05-13 (Wed, 13 May 2020)

  Changed paths:
    A lld/test/wasm/Inputs/sig_mismatch.s
    A lld/test/wasm/signature-mismatch-relocatable.s
    M lld/wasm/SymbolTable.cpp

  Log Message:
  -----------
  [lld][WebAssembly] Fix for --relocatable and signature mismatches

This is a followup to https://reviews.llvm.org/D78779.

When signatures mismatch we create set of variant symbols.  Some of
the fields in these symbols were not be initialized correct.
Specifically we were seeing isUsedInRegularObj not being set correctly,
leading to the symbol not getting included in the symbol table
and a crash writing relections in --reloctable mode.

There is larger refactor due here, but this is a minimal change the
fixes the bug at hand.

Differential Revision: https://reviews.llvm.org/D79756




More information about the All-commits mailing list