[all-commits] [llvm/llvm-project] ba8982: [lldb/test] Make "inline" tests handle multiple st...

Pavel Labath via All-commits all-commits at lists.llvm.org
Mon May 11 07:38:15 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ba898282bc204f78016c2e7779dc5cde37e10fd1
      https://github.com/llvm/llvm-project/commit/ba898282bc204f78016c2e7779dc5cde37e10fd1
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lldbinline.py
    M lldb/test/API/commands/expression/dollar-in-variable/main.c

  Log Message:
  -----------
  [lldb/test] Make "inline" tests handle multiple statements at the same location

Summary:
The test machinery translates each continuous block of "//%" comments
into a single breakpoint. If there's no code between the blocks the
breakpoints will end up at the same location in the program. When the
process stops at a breakpoint lldb correctly reports all breakpoint IDs,
but the test machinery only looks at the first one. This results in a
very dangerous situation as it means some checks can be silently
stopped.

This patch fixes that by making the test machinery iterate through all
breakpoints at a given location and execute all commands.

Reviewers: vsk, JDevlieghere

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D79563




More information about the All-commits mailing list