[all-commits] [llvm/llvm-project] f8af9f: [lldb] Add missing nullptr checks to AppleObjCRunt...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Mon May 11 07:03:30 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f8af9f5fca7dac5479a43837daa3e2bd897b00b7
      https://github.com/llvm/llvm-project/commit/f8af9f5fca7dac5479a43837daa3e2bd897b00b7
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp

  Log Message:
  -----------
  [lldb] Add missing nullptr checks to AppleObjCRuntime::GetBacktraceThreadFromException

Summary:
We got a few crash reports where LLDB crashes while derefencing the `frames_value` shared_ptr in the AppleObjCRuntime::GetBacktraceThreadFromException. `GetChildMemberWithName` returns a nullptr when an error occurs, so this seems to be just a missing nullptr check.

This patch adds that nullptr check and the other ones in the similar code directly below.

Fixes rdar://62174039

Reviewers: jingham, kubamracek

Reviewed By: jingham

Subscribers: abidh, JDevlieghere

Differential Revision: https://reviews.llvm.org/D78798




More information about the All-commits mailing list