[all-commits] [llvm/llvm-project] 77ecf9: [COFF] Migrate COFFObjectFile to Expected<T>

[Reid Kleckner via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 77ecf90c52641aadedf6bad7c8bea5b217b49729
      https://github.com/llvm/llvm-project/commit/77ecf90c52641aadedf6bad7c8bea5b217b49729
  Author: Reid Kleckner <rnk at google.com>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M lld/COFF/Chunks.cpp
    M lld/COFF/InputFiles.cpp
    M lld/COFF/Symbols.cpp
    M llvm/include/llvm/Object/COFF.h
    M llvm/lib/Object/COFFObjectFile.cpp
    M llvm/tools/llvm-objcopy/COFF/Reader.cpp
    M llvm/tools/llvm-objdump/COFFDump.cpp
    M llvm/tools/llvm-readobj/COFFDumper.cpp
    M llvm/tools/obj2yaml/coff2yaml.cpp

  Log Message:
  -----------
  [COFF] Migrate COFFObjectFile to Expected<T>

I noticed that std::error_code() does one-time initialization. Avoid
that overhead with Expected<T> and llvm::Error. Also, it is consistent
with the virtual interface and ELF, and generally cleaner.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D79643