[all-commits] [llvm/llvm-project] fcf10d: Reland [lldb][cmake] Also use local submodule visi...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fcf10d19081029a0b6aa6933b72c63425425866a
      https://github.com/llvm/llvm-project/commit/fcf10d19081029a0b6aa6933b72c63425425866a
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M llvm/CMakeLists.txt

  Log Message:
  -----------
  Reland [lldb][cmake] Also use local submodule visibility on Darwin

Relanding this as D79632 should fix the macOS tests with this option.

Original commit:

Summary:
Currently building LLVM on macOS and on other platforms with LLVM_ENABLE_MODULES is using different module flags,
which means that a passing modules build on macOS might fail on Linux and vice versa. -fmodules-local-submodule-visibility
is the mode that has clearer semantics and is closer to the actual C++ module standard, so let's make this the default everywhere.

We can still test building without local submodule visibility on an additional bot by just changing the respective CMake flag. However,
if building without local-submodule-visibility breaks we won't revert other commits and we won't loose LLDB's/Clang's test run
information.

Reviewers: aprantl, bruno, Bigcheese

Reviewed By: Bigcheese

Subscribers: abidh, dexonsmith, JDevlieghere, lldb-commits, mgorny, llvm-commits

Tags: #llvm, #lldb

Differential Revision: https://reviews.llvm.org/D74892