[all-commits] [llvm/llvm-project] 7cf4ab: [lldb][modules] Disable Clang Modules in source/Ho...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Fri May 8 09:14:29 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7cf4ab13af8aa3183e551b3319399cddd9384948
      https://github.com/llvm/llvm-project/commit/7cf4ab13af8aa3183e551b3319399cddd9384948
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M lldb/source/Host/CMakeLists.txt

  Log Message:
  -----------
  [lldb][modules] Disable Clang Modules in source/Host directory on macOS

Summary:
The arpa/inet.h header in macOS is providing an incorrect htonl
function with enabled local submodule visibility while building LLDB. This
caused several networking tests to fail as the IP addresses are now flipped
in LLDB.

This patch disables building with modules when local submodule visibility is
active and the current system is macOS for the source/Host directory (which
is the *only directory that includes arpa/inet.h).

* debugserver also includes arpa/inet.h but there we already disabled
modules.

Reviewers: aprantl

Reviewed By: aprantl

Subscribers: mgorny, JDevlieghere

Differential Revision: https://reviews.llvm.org/D79632




More information about the All-commits mailing list