[all-commits] [llvm/llvm-project] e9b411: Add a flag that controls if clang-tidy and clang-i...

Nico Weber via All-commits all-commits at lists.llvm.org
Fri May 8 08:42:06 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e9b4113902850667e4e96b0aabe158b87670d051
      https://github.com/llvm/llvm-project/commit/e9b4113902850667e4e96b0aabe158b87670d051
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-05-08 (Fri, 08 May 2020)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/tools/libclang/CMakeLists.txt
    M llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn

  Log Message:
  -----------
  Add a flag that controls if clang-tidy and clang-include-fixer are built into libclang.

Based on the discussion on D55415, also make the flag default to false.
Having libclang depend on clang-tools-extra means check-clang builds all
of clang-tools-extra, which besides being a layering violation takes
quite some time, since clang-tools-extra has many files that are slow
to compile.

Longer term, we likely will want to remove this flag completely. If
people need this functionality, maybe there could be a
libclang-tools-extra that's libclang + clang-tidy and
clang-includes-fixer linked in.

Differential Revision: https://reviews.llvm.org/D79599




More information about the All-commits mailing list